| title: | RE REVIEW PATCH 09 14 OMAP CAM Add ISP C |
|
Hi Nate,
-----Original Message-----
From: DongSoo(Nathaniel) Kim [ rel="nofollow" mailto:dongsoo.kim@xxxxxxxxx mailto:dongsoo.kim@xxxxxxxxx ]
Sent: Monday, March 02, 2009 2:10 AM
To: Aguirre Rodriguez, Sergio Alberto
Cc: linux-omap@xxxxxxxxxxxxxxx; video4linux-list@xxxxxxxxxx; Nagalla,
Hari; Sakari Ailus; Tuukka.O Toivonen; linux-media@xxxxxxxxxxxxxxx
Subject: Re: [REVIEW PATCH 09/14] OMAP: CAM: Add ISP Core
Hello,
reviewing ISP driver, I found that weve got no querymenu support in
ISP and also omap3 camera interface driver.
Sakari is about to repost our latest progress on this driver, and exactly one of the changes we did is added this support for querymenu on both camera and ISP drivers.
+/**
+ * struct vcontrol - Video control structure.
+ * @qc: V4L2 Query control structure.
+ * @current_value: Current value of the control.
+ */
+static struct vcontrol {
+ struct v4l2_queryctrl qc;
+ int current_value;
+} video_control[] = {
<snip
+ {
+ {
+ .id = V4L2_CID_PRIVATE_ISP_COLOR_FX,
+ .type = V4L2_CTRL_TYPE_INTEGER,
+ .name = "Color Effects",
+ .minimum = PREV_DEFAULT_COLOR,
+ .maximum = PREV_BW_COLOR,
+ .step = 1,
+ .default_value = PREV_DEFAULT_COLOR,
+ },
+ .current_value = PREV_DEFAULT_COLOR,
+ }
+};
I think we should make it menu type for this color FX control.
If that kind of control has no menu information, user has no way to
figure out what kind of FX supported by device.
BTW if we make querymenu support in omap3 camera subsystem, we should
make querymenu support for v4l2 int device also.
I think Ive seen before a patch which intent to use querymenu in v4l2
int device, but no patch for omap3 ISP and camera interface.
Can I make a patch and post on linux-omap, linux-media list? of course
if you dont mind.
Or...am I digging wrong way? I mean.. querymenu for omap3 camera subsystem.
Please let me know :)
Please hold a bit, as we expect to repost the driver again this week.
This control is now substituted by V4L2_CID_COLORFX, with seems to be already accepted for merging into v4l:
rel="nofollow" osdir.com/ml/linux-media/2009-02/msg00593.html osdir.com/ml/linux-media/2009-02/msg00593.html
Anyways, thanks for your intended help on this. Expect new patches very soon.
Cheers,
Nate
--
========================================================
DongSoo(Nathaniel), Kim
Engineer
Mobile S/W Platform Lab.
Telecommunication R&D Centre
Samsung Electronics CO., LTD.
e-mail : dongsoo.kim@xxxxxxxxx
dongsoo45.kim@xxxxxxxxxxx
========================================================
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at rel="nofollow" vger.kernel.org/majordomo-info.html vger.kernel.org/majordomo-info.html
|
